-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLOUDP-192976: Unit test everything but int and e2e #1075
Conversation
I might send an update for this, I think we can even get |
Note if we take this route I need to make some changes to the wording at #1066 |
3e541df
to
13073b8
Compare
13073b8
to
a7511f1
Compare
a7511f1
to
2c5fabf
Compare
Will wait for #1079 and rebase after it lands |
Signed-off-by: Jose Vazquez <jose.vazquez@mongodb.com>
2c5fabf
to
9e15097
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good in general 👍 One nit regarding ENV variables verification
This is an alternative to #1068 avoiding the use of build tags to achieve the same main goal.
It is a simpler change and we keep the project build tag free using explicit env vars to activate the int and e2e tests instead.
Uses 2 tricks:
go list ./...
and remove thetest/int
andtest/e2e
tests from the unit test set explicitly.go test ./...
to run unmolested by requiring a env var to explicitly enable the int or e2e tests.AKO_INT_TEST=1
enables int tests.AKO_E2E_TEST=1
enables e2e tests.All Submissions:
closes #XXXX
in your comment to auto-close the issue that your PR fixes (if there is one).